Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete TestFixtures.fixture_path= DEPRECATION WARNING (for support Rails 7.2) #1751

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

naitoh
Copy link

@naitoh naitoh commented Nov 21, 2024

Why?

rspec-rails 5.x does not work with Rails 7.2.

$ BUNDLE_GEMFILE=gemfiles/rails_7_1.gemfile bundle exec rake
[Coveralls] Set up the SimpleCov formatter.
[Coveralls] Using SimpleCov's 'rails' settings.
====> Doorkeeper ORM: 'active_record'
====> Doorkeeper version: 5.8.0
====> Rails version: 7.1.5
====> Ruby version: 3.2.2 on arm64-darwin22
DEPRECATION WARNING: TestFixtures.fixture_path= is deprecated and will be removed in Rails 7.2. Use .fixture_paths= instead. (called from <top (required)> at ...

https://github.com/rspec/rspec-rails/blob/v6.1.0/Changelog.md

6.1.0 / 2023-11-21
Support for Rails 7.1

6.0.2 / 2023-05-04
Support Rails 7.1's #fixtures_paths in example groups (removes a deprecation warning). (Nicholas Simmons, #2664)

## Why?
rspec-rails 5.x does not work with Rails 7.2.

```
$ BUNDLE_GEMFILE=gemfiles/rails_7_1.gemfile bundle exec rake
[Coveralls] Set up the SimpleCov formatter.
[Coveralls] Using SimpleCov's 'rails' settings.
====> Doorkeeper ORM: 'active_record'
====> Doorkeeper version: 5.8.0
====> Rails version: 7.1.5
====> Ruby version: 3.2.2 on arm64-darwin22
DEPRECATION WARNING: TestFixtures.fixture_path= is deprecated and will be removed in Rails 7.2. Use .fixture_paths= instead. (called from <top (required)> at ...
```

https://github.com/rspec/rspec-rails/blob/v6.1.0/Changelog.md
> 6.1.0 / 2023-11-21
> Support for Rails 7.1

> 6.0.2 / 2023-05-04
> Support Rails 7.1's #fixtures_paths in example groups (removes a deprecation warning). (Nicholas Simmons, #2664)
@naitoh naitoh marked this pull request as ready for review November 21, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant