update Go version, alpine, golangci and gotestsum

[converge]

Signed-off-by: João Vanzuita [email protected]

- What I did

Updated
Go version to 1.18
Docker CLI to 20.10.12
ALPINE Docker image to 3.15.4
GoLang Lint to 1.45.2
Go Test Sum to 1.8.0

- How I did it

Updating software version and testing it manually on a Mac M1.

- How to verify it

Build the project without cache.

- Description for the changelog

Update Go Lang to 1.8 and update overall dependencies to the most recent versions.

p.s: before we merge, it would be nice to test on Linux and Windows.

- A picture of a cute animal (not mandatory)

[silvin-lubecki]

The linter is failing:

#13 0.745 go: added github.com/kunalkushwaha/ltag v0.2.3
#13 0.748 ERROR: ltag not found. Install with:
#13 0.748     go get -u github.com/kunalkushwaha/ltag

We should fix it with

$ go install github.com/kunalkushwaha/ltag

Can you handle it @converge ?

[converge]

The linter is failing:

#13 0.745 go: added github.com/kunalkushwaha/ltag v0.2.3
#13 0.748 ERROR: ltag not found. Install with:
#13 0.748     go get -u github.com/kunalkushwaha/ltag

We should fix it with

$ go install github.com/kunalkushwaha/ltag

Can you handle it @converge ?

sure thing! go install ...@version did the trick.

[thaJeztah]

@silvin-lubecki do you prefer to keep the go version pinned to minor releases? (1.18.1 currently)? (same for the Dockerfile probably).

Slightly confused why we define defaults for them both as a make var and as a default var in the Dockerfile though; I think if we'd change the Makefile to remove the =$(VARIABLE), the build-args should take the value from the environment (if set), and otherwise take the default from the Dockerfile, i.e., something like:

BUILD_ARGS:=--build-arg GO_VERSION \
    --build-arg CLI_VERSION \
    --build-arg ALPINE_VERSION \
    --build-arg GOLANGCI_LINT_VERSION) \
    --build-arg TAG_NAME \
    --build-arg GOTESTSUM_VERSION \
    --build-arg BINARY_NAME \
    --build-arg BINARY

[converge]

if I can jump in.. keep up with 1.18 (1.18.x) would be nice, since it uses the most recent version, and the minor changes from Go are usually security updates.

Regarding point 2, you're right, we were setting the dependencies at the Makefile and var.mk file. I updated the Dockerfile to only read the ARG values from the Makefile (that sets the ARG values). WDYT?

[thaJeztah]

I'd rather keep the defaults in the Dockerfile if that works, that way the Dockerfile itself has usable defaults, which allows it to be built without having to pass specific build args.

Not near my computer to try if that works though ☺️

[silvin-lubecki]

Good catch @thaJeztah 👍

[thaJeztah]

While we're updating; could you make this 20.10.14 (which is latest)? (same for the Dockerfile)

[williamdes]

Let's go to 3.17 now