Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce calls to _all_dbs when validating the PSet for a new workflow #11351

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

amaltaro
Copy link
Contributor

Fixes #11330

Status

In development

Description

Lots of debugging here while I was trying to understand the problem, which will be removed once the HTTP team work on the cmsweb frontend issue (whatever that issue is...).

For now, this PR provides the following:

  • remove unused module WMCore/JobStateMachine/ConfigureState.py
  • whenever a WMConfigCache object is created, e.g. when loading a PSet during workflow creation, do not check whether CouchDBName actually exists (it's always meant to be reqmgr_config_cache).

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

None

External dependencies / deployment changes

None

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 tests no longer failing
    • 1 changes in unstable tests
  • Python3 Pylint check: failed
    • 22 warnings and errors that must be fixed
    • 4 warnings
    • 266 comments to review
  • Pylint py3k check: failed
    • 1 warnings
  • Pycodestyle check: succeeded
    • 60 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13686/artifact/artifacts/PullRequestReport.html

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: failed
    • 142 new failures
    • 14 tests deleted
    • 2 tests no longer failing
    • 11 changes in unstable tests
  • Python3 Pylint check: failed
    • 55 warnings and errors that must be fixed
    • 10 warnings
    • 480 comments to review
  • Pylint py3k check: failed
    • 1 warnings
  • Pycodestyle check: succeeded
    • 103 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13711/artifact/artifacts/PullRequestReport.html

@cmsdmwmbot
Copy link

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WMCore services reported being slow
2 participants