Fix empty reads

[sapfeer0k]

Fist of all , I believe this is a very much needed tool for developers and I would be happy to see this released as a docker plugin :)

I tried to play with it but stuck with an error. All my attempts to read content of the file were failing. I am using go 1.18.1 and it turns out File.ReadAt function always return EOF error if data read from the file is less than the allocated buffer size (docs https://go.dev/src/os/file.go?s=7686:7723)

I had to tweak error handler to let the data be returned in that special case

[dguerri]

@sapfeer0k, thanks! Good catch and investigation!

The EOF error is handled here in the client so effectively you are getting no data.

I think you are doing the right thing by "ignoring" the EOF error and returning what's in the buffer, as the read() in the go-fuse client, can't have the same behaviour as readAt()

It would be great to have a unit test to prevent regressions :)

[dguerri]

LGTM.

[dguerri]

If you feel like, please add a unit test.
If not I will add it later.

[sapfeer0k]

Hi, sure, I will try to add a unit test for this specific case, although go is not my native language.