Update 08-nasa-metadata.Rmd #107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update id definition to reflect current NASA metadata (metadata$dataset$identifier) as per issue dgrtwo#72
|
Thank you for this contribution @enzedonline! 🙌 This change will require rewriting most of this chapter so we are going to wait on this for now. |
|
This change worked for me. The only part of the book I couldn't get to work was the finance section. Tried changing the feed to yahoo, but that seems to be off as well now. Thanks for the great book, its been immensely helpful! |
Repository owner
deleted a comment from
dev881B
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update id definition to reflect current NASA metadata (metadata$dataset$identifier) as per issue #72