Make the min-width a bit smaller for mobile #2119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nmattia Doing this will make the screens tighter on all smaller devices. |
|
@meodai can't we keep the current size but limit the text width for that one problematic screen? sacrificing real estate on all screens just for one loader seems a bit odd |
|
@nmattia I don't see how we are sacrificing real-estate. Min-width is only the minimum size the container should have, if it has more content it gets wider. The text-width is not the issue on that particular screen. |
nmattia
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid overflow issues on smaller phones
🟢 Some screens were added
🟡 Some screens were changed