feat: add Agent Manager to utils package #731
Conversation
size-limit report 📦
|
| }, | ||
| })); | ||
|
|
||
| jest.mock("./nullish.utils", () => ({ |
There was a problem hiding this comment.
You need to mock this?
There was a problem hiding this comment.
apparently yes... when i ran the test without, it said that it couldn't find it... I will re-try and let you know
| @@ -42,3 +42,102 @@ export const createAgent = async ({ | |||
| shouldFetchRootKey: fetchRootKey, | |||
| }); | |||
| }; | |||
|
|
|||
| export interface AgentManagerConfig { | |||
There was a problem hiding this comment.
In another PR, we should extract an interface for all the paramters of @dfinity/utils.createAgent and this interface become a subtype of this new interface.
export type AgentManagerConfig = Omit<NewInterface, 'identity'>
There was a problem hiding this comment.
ah! right! shall i do it before this one? i think it would be a fast one
There was a problem hiding this comment.
|
In addition:
|
|
Yes at the top, in
Nvm, my bad. Assumed it was a brand new separate module. All good. |
Motivation
It is a simple but useful class to manage multiple HTTP agents associated with identities.
Credits
The original scripts were created by @peterpeterparker in the OISY repo. This is just a transposition to a re-usable utility.
Changes
New
AgentManagerclass with:createmethod: static constructor.createAgentmethod: as the name suggests, it creates a new HTTP but do not cache it.getAgentmethod: it fetches the HTTP agent among the cached, and if does note exists, it creates it and cache it.clearAgentsmethod: clean slate.Tests
I created a few tests for the few usecases.
Todos