Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: agent-js v2.0.0 #679

Merged
merged 8 commits into from
Aug 26, 2024
Merged

feat: agent-js v2.0.0 #679

merged 8 commits into from
Aug 26, 2024

Conversation

peterpeterparker
Copy link
Member

@peterpeterparker peterpeterparker commented Jul 22, 2024

Motivation

Bump agent-js v2.0.0 (release notes) and update HttpAgent creation accordingly.

Changes

  • npm run update:agent
  • Defer fetching root key to HttpAgent.create in the createAgent which per extension also improve the creation of the agent by also calling syncTime
  • For defaultAgent simply replace contructor call with synchronous HttpAgent.createSync

Signed-off-by: David Dal Busco <[email protected]>
Copy link
Contributor

github-actions bot commented Jul 22, 2024

size-limit report 📦

Path Size
@dfinity/ckbtc 7.91 KB (0%)
@dfinity/cketh 3.45 KB (0%)
@dfinity/cmc 1.29 KB (0%)
@dfinity/ledger-icrc 3.89 KB (0%)
@dfinity/ledger-icp 15.23 KB (0%)
@dfinity/nns 36.62 KB (0%)
@dfinity/nns-proto 140.98 KB (0%)
@dfinity/sns 15.92 KB (0%)
@dfinity/utils 4.5 KB (-0.05% 🔽)
@dfinity/ic-management 2.92 KB (0%)

Signed-off-by: David Dal Busco <[email protected]>
Signed-off-by: David Dal Busco <[email protected]>
@peterpeterparker peterpeterparker marked this pull request as ready for review July 22, 2024 06:45
@peterpeterparker peterpeterparker requested review from a team as code owners July 22, 2024 06:45
@peterpeterparker peterpeterparker marked this pull request as draft July 22, 2024 06:46
Signed-off-by: David Dal Busco <[email protected]>
@peterpeterparker peterpeterparker changed the title build: bump agent-js v2.0.0 feat: agent-js v2.0.0 Jul 22, 2024
@peterpeterparker peterpeterparker marked this pull request as ready for review July 22, 2024 06:52
@dskloetd
Copy link
Collaborator

Will this require changes in nns-dapp when we update the ic-js deps in nns-dapp?
Would it be a good idea to test this in nns-dapp before merging here in case it is more work to make it work in nns-dapp?

@peterpeterparker
Copy link
Member Author

Let me put it in draft and I do some testing first.

I don't think it will require changes in NNS dapp.

@peterpeterparker peterpeterparker marked this pull request as draft July 22, 2024 14:44
@peterpeterparker
Copy link
Member Author

Indeed does not require any particular changes in NNS dapp except adapt the agent similarly as in this PR in dev.api.ts.
See PR dfinity/nns-dapp#5274

@peterpeterparker peterpeterparker marked this pull request as ready for review August 26, 2024 09:28
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

packages/utils/src/utils/agent.utils.ts Show resolved Hide resolved
@peterpeterparker peterpeterparker requested review from a team and removed request for a team August 26, 2024 10:03
@peterpeterparker peterpeterparker merged commit 497c8ba into main Aug 26, 2024
22 checks passed
@peterpeterparker peterpeterparker deleted the build/bump-agent-js-v2 branch August 26, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants