feat: enforce usage of nullish check utils #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
An useful rule is to enforce the usage of utils
isNullish
andnonNullish
from repo @dfinity/utils for a simple nullish comparison.isNullish
Incorrect
Correct
nonNullish
Incorrect
Correct
Future Improvements
The rule will be improved to recognize nullish check even with the following cases (and their negation counterparty):
Tests
Create specific tests for the new rule.