Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added integration with OpenID Connect Authelia #78

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

arbdevml
Copy link

No description provided.

@triplem
Copy link
Contributor

triplem commented Apr 30, 2023

This PR would only allow authelia in the future. Why not just use the keycloak way only?

@arbdevml
Copy link
Author

Why not just use the keycloak way only?

Because this plugin has to support OpenID providers as many as possible.

This PR would only allow authelia in the future.

One row was updated only in this pull request.
This pull request didn't remove the support of Keycloak.

Before update:
177: if access_token? # keycloak way...
After update:
191: if (access_token? && access_token.exclude?('authelia')) # keycloak way...

Explanation:
if condition true (access_token? && access_token.exclude?('authelia'))
it means the OpenID provider is Keycloak
else have to use another provider like Authelia.

Could you review this pull request, please.
Could you explain why you don't want to apply this pull request, please?

@arbdevml
Copy link
Author

arbdevml commented Jul 7, 2023

triplem, is there any issues with it, or should I add something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants