Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keycloak add gruops support and French messages #39

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

kazimsarikaya
Copy link

The pr consists of two parts

  1. Some keycloak users use group membership mapping and add groups field to the response.
  2. Error messages are in French. I translate them to the English.

C0rn3j added a commit to C0rn3j/redmine_openid_connect that referenced this pull request Sep 22, 2020
@C0rn3j
Copy link

C0rn3j commented Sep 22, 2020

This does not seem to work, tested on Redmine 4.1.0.

Might be a KC misconfiguration on my side, but am not clear as to where.

I get this upon login:

Started GET "/oic/local_login?state=<censored>&session_state=<censored>&code=<censored>" for 10.123.123.11 at 2020-09-23 01:27:47 +0200
Processing by AccountController#oic_local_login as HTML
  Parameters: {"state"=>"f<censored>", "session_state"=>"<censored>", "code"=>"<censored>"}
  Current user: anonymous
Completed 500 Internal Server Error in 227ms (ActiveRecord: 14.0ms)
  
NoMethodError (undefined method `each' for nil:NilClass):
  
plugins/redmine_openid_connect/lib/redmine_openid_connect/account_controller_patch.rb:196:in `update_groups'
plugins/redmine_openid_connect/lib/redmine_openid_connect/account_controller_patch.rb:150:in `oic_local_login'
lib/redmine/sudo_mode.rb:65:in `sudo_mode'
Started GET "/" for 127.0.0.1 at 2020-09-23 01:27:57 +0200
Processing by WelcomeController#index as */*
  Current user: anonymous
Redirected to http://127.0.0.1/login?back_url=http%3A%2F%2F127.0.0.1%2F
Filter chain halted as :check_if_login_required rendered or redirected
Completed 302 Found in 10ms (ActiveRecord: 2.0ms)

kazimsarikaya and others added 8 commits April 3, 2021 09:05
Signed-off-by: Kazım SARIKAYA <[email protected]>
* Adding support to FusionAuth roles

* Adding support to FusionAuth role step by step doc

Co-authored-by: Einar Lanfranco <[email protected]>
Without this change, any logged in user is able to access /admin
…exist (devopskube#49)

* Added Support for login selector (external or sso); Added pt translation;

* Added feature to choose whehter to create or not users if they don't exist

* Added feature to avoid direct login from selected auth sources

* Added two important conditions for the feature to run

Co-authored-by: Tiago Gomes <[email protected]>
add user groups at login
Signed-off-by: Kazım SARIKAYA <[email protected]>
@kazimsarikaya kazimsarikaya force-pushed the master branch 3 times, most recently from af5e944 to 7994ec5 Compare April 6, 2021 19:18
@homerpirado
Copy link

Efectivamente @C0rn3j a mi tampoco me funciona con la version 4.X ¿Pudiste solucionarlo de alguna manera?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants