access token query modifications #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
client_id and client_secret added to support client_secret_post based auth on token request
id_token and scope are not valid variables in access token query. (https://connect2id.com/learn/openid-connect codeflow step2)
triplem
reviewed
Nov 17, 2017
| @@ -181,8 +181,6 @@ def access_token_query | |||
| query = { | |||
| 'grant_type' => 'authorization_code', | |||
| 'code' => code, | |||
| 'scope' => 'openid profile email user_name', | |||
There was a problem hiding this comment.
On https://nat.sakimura.org/2012/01/26/scopes-and-claims-in-openid-connect/ the following can be found:
profile – OPTIONAL. This requests that access to the End-User’s profile Claims excluding the address and email Claims at the UserInfo Endpoint be granted by the issued Access Token.
email – OPTIONAL. This requests that access to the email and verified Claims at the UserInfo Endpoint be granted by the issued Access Token.
I guess, removing all of the above in the scope does not really makes sense, does it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified access token query to support client_secret_post based token query