Add helm chart #40
Open
Add helm chart #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@DrackThor is it possible to maintain helm chart in the separate github repo? Does it make sense, what do you think? |
|
For helm chart, I am glad to help review this change. But at first, I'd like to see how many users are looking forward to this feature. If someone likes this feature, feel free to add a thumb emoj in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've split the old PR #39 into two new PRs, this one contains the HELM chart.
Maybe we need to sort out some merge conflicts in the README.md since I've modified it in both PRs.
This chart creates a cronJob and deploys the container from the other PR.
Configuration is done via env variables, injected via a configMap.
Feedback is most welcome! 😄