mm_loader.c: fix callback loader #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the last major issue I found when upgrading to Calico. (Corrupted samples when loading the soundbank from a compressed archive.)
This is one possible solution of the issue (replacing accesses of
s_mmFile.hdrwiths_mmState). If you'd prefer me to implement it by filling the fields ins_mmFile.hdrinmmSetCustomSoundBankHandler, I can change to that implementation.[By the way, were my email and forum message received? I understand if you are all busy, but I never heard anything back. The major issues are all solved but there are still some minor things I'd like to discuss. Thanks!]