Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support SV, especially SV1_DESI_TARGET #494

Merged
merged 5 commits into from
May 30, 2019
Merged

support SV, especially SV1_DESI_TARGET #494

merged 5 commits into from
May 30, 2019

Conversation

sbailey
Copy link
Contributor

@sbailey sbailey commented May 29, 2019

Updates to support the simulation chain with SV1_DESI_TARGET in prep for Survey Validation.

@michaelJwilson please try this "sv" branch with fastframe and report any problems to this PR and we'll get them fixed as part of this update.

@michaelJwilson
Copy link

Changes implemented so far look good. I didn't look at the complete code, so I can't testify further changes aren't required. I assume you want to deal with #493 on the sv branch first before merging?

Copy link

@michaelJwilson michaelJwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes implemented so far look good. I didn't look at the complete code, so I can't testify further changes aren't required. Given #493 is done, seems good to merge.

The current implementation for fastframe and clobber will work, I was just wondering if you really want write_frame to default to overwrite without the option to change it.

@sbailey
Copy link
Contributor Author

sbailey commented May 30, 2019

Let's punt the remaining fast frame clobber question to a future issue / PR / decision and merge this now. I think it's ok to have fastframe overwrite outputs when called. The original reason for wrap-fastframe not doing that was for "pick up where you left off" -- if a job timed out you could just rerun the exact same wrap-fastframe command and it would just continue with any remaining pixels, without crashing on pre-existing pixels nor wastefully regenerating them, and without requiring the user to update the list of requested healpix.

@sbailey sbailey merged commit 879f87d into master May 30, 2019
@sbailey sbailey deleted the sv branch May 30, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants