Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update picocolors and @types/node version dependency #410

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

UrielCh
Copy link
Contributor

@UrielCh UrielCh commented May 22, 2024

Picocolors used to not receive any updates, but last week it was updated to version 1.0.1. See changelog.

Having up-to-date dependencies improves the npm quality score. Since the deno + dnt project aims to be better than other projects, maintaining a good score is essential. 👯

By the way, I also updated the versions of @types/node and @deno/shim-deno.

@UrielCh
Copy link
Contributor Author

UrielCh commented May 23, 2024

I will fix that soon, I saw CI failed.

@UrielCh
Copy link
Contributor Author

UrielCh commented Sep 10, 2024

@dsherret sorry for the delay, Let me complet this PR.

I have add an extra const versions to put some versions number togeter.

So I have now two times the same versions object, maybe I should export it and share it to avoid duplication.

let me know.

by the way, I had also update @types/node version, but only to the latest v20.X.Y

@UrielCh
Copy link
Contributor Author

UrielCh commented Sep 10, 2024

I can also add in lib/shims.ts

const versions = {
  denoShim: "~0.19.1",
  denoTestShim: "~0.5.0",
  cryptoShim: "~0.3.1",
  domExceptionShim: "^4.0.0",
  domExceptionShimTypes: "^4.0.0",
  promptsShim: "~0.1.0",
  timersShim: "~0.1.0",
  weakRefSham: "~0.1.0",
  undici: "^6.0.0",
  ws: "^8.13.0",
  wsType: "^8.5.4",
};

to centralise all version from the file, this versions object will then looks like the on present in tests/integration.test.ts but will differ by 3 versions entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant