Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: root package has peer dependency on itself #70

Merged
merged 2 commits into from
Oct 3, 2024
Merged

fix: root package has peer dependency on itself #70

merged 2 commits into from
Oct 3, 2024

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Oct 3, 2024 •
edited
Loading

Fix for denoland/deno#26006

{
    "name": "@univerjs/core",
    "version": "0.3.0",
    "private": false,
    "peerDependencies": {
        "@univerjs/core": "workspace:*",
    },
}

dsherret
dsherret requested changes Oct 3, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test?

dsherret
dsherret approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@littledivy littledivy merged commit a48a867 into main Oct 3, 2024
1 check passed
@littledivy littledivy deleted the root_self_peer_panic branch October 3, 2024 13:33
@littledivy littledivy mentioned this pull request Oct 3, 2024
Merged
littledivy added a commit to denoland/deno that referenced this pull request Oct 3, 2024
@littledivy
fix(npm): root package has peer dependency on itself (#26022)
e41df20 
denoland/deno_npm#70

Fixes #26006
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@littledivy @dsherret