Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] destrucutre AggregateError #425

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

crowlKats
Copy link
Member

@crowlKats crowlKats commented Jan 8, 2024

The second test, which uses destructureError (underlying op being op_destructure_error), adds a frame for unknown reasons.

Additionally, for some reason, AggregregateErrors don't have any stack frames.

await Promise.any([]);
})()
"#;
let value_global = runtime
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance these could be integration and/or unit tests? I'd like to avoid adding more of these tests which are a bit awkward to maintain in Rust.

@bartlomieju
Copy link
Member

@littledivy did more digging into this problem and our current understanding is that it's a V8 problem - not sure if it's worth investing resources right now to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants