[WIP] Add REPL example #415
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
commented
Jan 4, 2024
| @@ -0,0 +1,528 @@ | |||
| // Copyright 2018-2024 the Deno authors. All rights reserved. MIT license. | |||
|
|
|||
| use deno_core::serde::Deserialize; | |||
There was a problem hiding this comment.
Upstream it in a separate PR
ry
reviewed
Jan 5, 2024
core/examples/repl.rs
Outdated
Comment on lines
96
to
108
| pub enum EvaluationOutput { | ||
| Value(String), | ||
| Error(String), | ||
| } | ||
|
|
||
| impl std::fmt::Display for EvaluationOutput { | ||
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | ||
| match self { | ||
| EvaluationOutput::Value(value) => f.write_str(value), | ||
| EvaluationOutput::Error(value) => f.write_str(value), | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
It's copy-pasted from cli/tools/repl. I'm trying to slim it down as much as possible so we can turn it into a runtime API to provide node:repl polyfill.
There was a problem hiding this comment.
Plus see #412 - Matt and I have been discussing this and we want to do a bin target to be able to test changes quickly without having to rebuilt deno itself (because iterating on deno_core is waaaaaay faster).
bartlomieju
added a commit
to denoland/deno
that referenced
this pull request
Jan 5, 2024
Some drive-by cleanup as I'm working through denoland/deno_core#415.
bartlomieju
added a commit
to denoland/deno
that referenced
this pull request
Jan 12, 2024
Some drive-by cleanup as I'm working through denoland/deno_core#415.
bartlomieju
added a commit
that referenced
this pull request
Jan 31, 2024
This commit adds minimal binary target to "deno_core" crate. It is now possible to "cargo run ./path/to/file.ts" to execute a file. This feature is being added for development and testing purposes only and is not meant for end-users. The API is minimal and the binary can't do anything interesting. "fs_module_loader" example has been removed in favor of binary target. Closes #412 Once #415 lands we can extend functionality further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #411