Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): fast Wasm streaming in Rust #349

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

littledivy
Copy link
Member

No description provided.

@littledivy littledivy changed the title Fast Wasm streaming in Rust fast Wasm streaming in Rust Nov 24, 2023
@littledivy littledivy marked this pull request as ready for review November 24, 2023 08:18
@@ -179,7 +186,6 @@ impl JsRealmInner {
std::mem::take(&mut realm_state.js_build_custom_error_cb);
std::mem::take(&mut realm_state.js_promise_reject_cb);
std::mem::take(&mut realm_state.js_format_exception_cb);
std::mem::take(&mut realm_state.js_wasm_streaming_cb);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably still take this one just in case there are globals in the closure. Eventually I'd like to get rid of that explicit intermediate take step but I can't guarantee right now we won't leak bits of the isolate right now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Matt here - can you verify this end-to-end in Deno repo if that doesn't cause problems before merging this PR?

Copy link
Contributor

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Net negative lines :)

@mmastrac mmastrac changed the title fast Wasm streaming in Rust feat(core): fast Wasm streaming in Rust Dec 2, 2023
@bartlomieju
Copy link
Member

Can this PR be landed now?

@mmastrac
Copy link
Contributor

Looks like this needs a re-merge but it doesn't look too bad.

@mmastrac
Copy link
Contributor

@littledivy Do you mind if I take a stab at re-merging and landing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants