fix(ext/webgpu): fix GPUAdapter#info fails and add GPUDevice#adapterInfo
#26844
+258
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@crowlKats Please take a look! |
Milad335t
reviewed
Nov 13, 2024
Milad335t
approved these changes
Nov 13, 2024
|
By initializing |
petamoriken
force-pushed
the
fix/webgpu-adapter-info
branch
from
420ea5e
to
8f1d20d
Compare
|
FYI @petamoriken i will be reviewing this alongside all other webgpu and graphics related PRs throughout the day today |
crowlKats
reviewed
Nov 23, 2024
There was a problem hiding this comment.
A problem with this is having to disable sanitizeResources. GPUAdapter as far as i know has no plans to be destroyable, which is the reason why we used take. I will have to bring this up in the next wgpu meeting to get a clearer idea of whats going on, so will have to wait until next week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #25874
Fix #26760
GPUAdaptercannot be destroyed manually, so this PR addsFinalizationRegistryto release its resource when GC'd.And, this PR adds
GPUDevice#adapterInfo.gpuweb/gpuweb#4809
https://groups.google.com/a/chromium.org/g/blink-dev/c/q4tpIeEydRI