Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/k8s-event-logger]: Enhance Helm Chart with Consistent Naming and Labeling Conventions #605

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

webdz9r
Copy link
Contributor

@webdz9r webdz9r commented Sep 25, 2024

Description

Enhance Helm Chart with Consistent Naming and Labeling Conventions

This pull request introduces several improvements to the Helm chart to ensure consistent naming and labeling across all Kubernetes resources. The changes include the addition of helper templates and the application of these templates in various resource definitions.

All templates now use the k8s-event-logger.labels helper. Name label is still used outside of the helper call

Source updated chart via this PR with more context and details

Diff Report previous vs proposed

diff new.yaml org.yaml
9c9
<     helm.sh/chart: k8s-event-logger-1.1.7
---
>     helm.sh/chart: k8s-event-logger-1.1.6
20c20
<     helm.sh/chart: k8s-event-logger-1.1.7
---
>     helm.sh/chart: k8s-event-logger-1.1.6
22d21
<     app.kubernetes.io/version: "2.1"
36c35
<     helm.sh/chart: k8s-event-logger-1.1.7
---
>     helm.sh/chart: k8s-event-logger-1.1.6
38d36
<     app.kubernetes.io/version: "2.1"
55,56c53,54
<     helm.sh/chart: k8s-event-logger-1.1.7
<     app.kubernetes.io/instance: test
---
>     app.kubernetes.io/name: k8s-event-logger
>     helm.sh/chart: k8s-event-logger-1.1.6
64d61
<       helm.sh/chart: k8s-event-logger-1.1.7
66,67d62
<       app.kubernetes.io/version: "2.1"
<       app.kubernetes.io/managed-by: Helm

Checklist

  • Title of the PR starts with chart name (e.g. [stable/mychartname])
  • I have read the contribution instructions, bumped chart version and regenerated the docs
  • Github actions are passing

@webdz9r webdz9r requested a review from a team as a code owner September 25, 2024 15:04
Copy link
Member

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you @webdz9r 💜

@max-rocket-internet max-rocket-internet merged commit 618e781 into deliveryhero:master Sep 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants