Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add workflows #2

Merged
merged 4 commits into from
May 22, 2024
Merged

ci: Add workflows #2

merged 4 commits into from
May 22, 2024

Conversation

shadeMe
Copy link
Contributor

@shadeMe shadeMe commented May 14, 2024

Ported from the haystack repo, with an additional nightly workflow to test against the main branch.

@shadeMe shadeMe requested review from masci and anakin87 May 14, 2024 11:17
@shadeMe shadeMe marked this pull request as ready for review May 14, 2024 11:18
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not entirely familiar with the details of the haystack-experimental project, so I would prefer that @masci also take a look.

Some doubts:

  • Not sure but some workflows seem outdated/no longer used and should also be removed from haystack (generate_openapi_specs.py).
  • In this project, do we need the workflows for documentation?

@shadeMe
Copy link
Contributor Author

shadeMe commented May 15, 2024

I am not entirely familiar with the details of the haystack-experimental project, so I would prefer that @masci also take a look.

Some doubts:

* Not sure but some workflows seem outdated/no longer used and should also be removed from haystack (`generate_openapi_specs.py`).

* In this project, do we need the workflows for documentation?
  • Yeah, I wasn't sure what was still used and what wasn't, so I tried to be conservative in removing them.
  • Yes, we do. We still need to figure out how to best deploy the docs, but we need to at least have a way of exposing the API docs of the experimental components to the user - Anything less would impede them from actually trying them out.

@masci
Copy link
Contributor

masci commented May 15, 2024

I would advocate to proceed the other way around, pulling in the workflows we need as we need them rather than cargo-loading Haystack CI and then remove.

@shadeMe
Copy link
Contributor Author

shadeMe commented May 16, 2024

I've now kept just the bare minimum (linting, testing, publishing) workflows needed to merge PRs and releasing packages.

@masci
Copy link
Contributor

masci commented May 16, 2024

A few questions:

  • I initially disabled the issue tracker, to avoid having one more place where to monitor issues (it's already some work moving issues from hasytack to haystack-core-integrations). Do we want to track issues for the experimental package?
  • Do we need to use reno for the release notes? A simpler approach might be using the github release generator that relies on PR titles

@shadeMe
Copy link
Contributor Author

shadeMe commented May 17, 2024

A few questions:

* I initially disabled the issue tracker, to avoid having one more place where to monitor issues (it's already some work moving issues from hasytack to haystack-core-integrations). Do we want to track issues for the experimental package?

* Do we need to use `reno` for the release notes? A simpler approach might be using the github release generator that relies on PR titles
  • Ah, I see - didn't notice that the issues were already disabled. I'll remove the templates then (agree that it's better to have all issues in the core repo).
  • Fine by me to make things even simpler. I've removed those workflows.

@shadeMe shadeMe requested review from silvanocerza and removed request for silvanocerza May 20, 2024 16:21
@masci masci merged commit c833979 into main May 22, 2024
5 checks passed
@masci masci deleted the ci/setup-tests branch May 22, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants