Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LLMMetadataExtractor serialisation #136

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

davidsbatista
Copy link
Contributor

Proposed Changes:

  • fix serialization

Checklist

@coveralls
Copy link

coveralls commented Nov 20, 2024

Pull Request Test Coverage Report for Build 11935729198

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 33 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-7.7%) to 81.899%

Files with Coverage Reduction New Missed Lines %
components/tools/tool_invoker.py 1 93.67%
components/tools/openai/function_caller.py 2 92.86%
components/tools/openapi/openapi_tool.py 3 58.43%
components/extractors/llm_metadata_extractor.py 5 63.64%
components/generators/chat/openai.py 22 88.48%
Totals Coverage Status
Change from base Build 11924112494: -7.7%
Covered Lines: 2303
Relevant Lines: 2812

💛 - Coveralls

@davidsbatista davidsbatista changed the title fix: fix LLMMetadataExtractor serialisation fix: LLMMetadataExtractor serialisation Nov 20, 2024
@davidsbatista davidsbatista marked this pull request as ready for review November 20, 2024 11:22
@davidsbatista davidsbatista requested a review from a team as a code owner November 20, 2024 11:22
@davidsbatista davidsbatista requested review from silvanocerza and sjrl and removed request for a team and silvanocerza November 20, 2024 11:22
@sjrl
Copy link
Collaborator

sjrl commented Nov 20, 2024

Hey @davidsbatista I think we are also missing page_range in the to_dict method as well.

Copy link
Collaborator

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants