Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal] Fix access to missing finalizers, always add default finalizer #110

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

astef
Copy link
Member

@astef astef commented Dec 10, 2024

Description

Fixes convert_bd_names_to_selector.py to handle LVGs without finalizers.

Link to backport to v0.4.

Why do we need it, and what problem does it solve?

Client upgrading from <=0.2.3 to >=0.4.0 may see errors in convert_bd_names_to_selector.py related to LVG finalizers being empty. After the current change, script will handle this case properly and add the default finalizer, if it doesn't exist.

What is the expected result?

  • clients with errors will update to current fix and see errors are gone
  • LVGs without the default finalizer will have one after the migration

Checklist

  • Changes were tested in the Kubernetes cluster manually.

@astef astef added the bug Something isn't working label Dec 10, 2024
@astef astef requested review from duckhawk and AleksZimin December 10, 2024 07:45
@astef astef self-assigned this Dec 10, 2024
@AleksZimin AleksZimin merged commit e61684e into main Dec 11, 2024
10 checks passed
@AleksZimin AleksZimin deleted the astef-fix-lvg-empty-finalizers branch December 11, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants