Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

That PR I keep mentioning. #70

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

That PR I keep mentioning. #70

wants to merge 31 commits into from

Conversation

yaleman
Copy link

@yaleman yaleman commented Dec 5, 2023

  • Docker builds and runs with local storage (and the container is auto-built on push to the main branch, and pushed to ghcr.io)
  • Config's all in a Pydantic model now.
  • loader.py can do multiple loads in a row so it's not starting up multiple times
  • SO much chasing types through flows
  • moved testing to use pytest (which meant renaming vigil-server.py)
  • ... probably other stuff I've forgotten

If there's anything you'd rather be done a particular way, don't hesitate, we all have our preferred ways of doing things 😄

@deadbits
Copy link
Owner

@yaleman Would you be able to break this PR down into separate PRs that are more feature specific? This is really hard to review and merge as one PR since I have to take all or nothing from this branch

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants