Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds support for segmentations that has SegmentIdentificationSequence… #164

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

adds support for segmentations that has SegmentIdentificationSequence… #164

wants to merge 5 commits into from

Conversation

emelalkim
Copy link
Contributor

… in SharedFunctionalGroupsSequence in Segmentation_3X and Segmentation_4X. Updates Segmentation_3X to support SourceImageSequence with one item and adds support for retrieval of SourceImageSequence from SharedFunctionalGroupsSequence in Segmentation_4X

@emelalkim
adds support for segmentations that has SegmentIdentificationSequence…
f85a6af 
… in SharedFunctionalGroupsSequence in Segmentation_3X and Segmentation_4X. Updates Segmentation_3X to support SourceImageSequence with one item and adds support for retrieval of SourceImageSequence from SharedFunctionalGroupsSequence in Segmentation_4X
@emelalkim
remove console
e4ea37c
@emelalkim
adds support for segmentations that has SegmentIdentificationSequence…
7ebc881 
… in SharedFunctionalGroupsSequence in Segmentation_3X and Segmentation_4X. Updates Segmentation_3X to support SourceImageSequence with one item and adds support for retrieval of SourceImageSequence from SharedFunctionalGroupsSequence in Segmentation_4X
@emelalkim
remove console
94f7424
@emelalkim
Merge branch 'fix/segmentationsharedgroup' of https://github.com/dcmj…
07e2cd4 
…s-org/dcmjs into fix/segmentationsharedgroup
@emelalkim emelalkim marked this pull request as draft January 29, 2021 23:59
pieper
pieper requested changes Feb 1, 2021
View reviewed changes
Copy link
Collaborator

@pieper pieper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. I don't have any way to test it but it looks backwards compatible.

If you change the commit message to something have a prefix like feat(seg) it will automatically trigger a minor version release to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieper pieper pieper requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emelalkim @pieper