Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pie-chart radius as per resizing of window. #1279

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

fatangare
Copy link
Contributor

@fatangare fatangare commented Feb 11, 2017

During resizing of pie-chart, chart is redrawn for given width and height but its radius is not changed making it to be cropped. Simple solution is to check if diameter is bigger than container...if yes, adjust radius accordingly.

During resizing of pie-chart, chart is redrawn for given width and height but it's radius is not changed making it to be cropped. Simple solution is to check if diameter is bigger than container...if yes, adjust radius accordingly.
@tttp
Copy link
Contributor

tttp commented Apr 17, 2017

Hi,

@fatangare have you tried with the responsive width(0) way? Does it behave properly in that case?

@gordonwoodhull
Copy link
Contributor

I doubt that would help, however another workaround is just to not set the radius and let it be derived from the width/height.

I'm in favor of this PR, sorry I have not yet had time to merge it. Since it doesn't change the API it should be okay for the 2.0 branch.

@gordonwoodhull gordonwoodhull added this to the v2.0 milestone Apr 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants