Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a pyramid chart. #1053

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

adding a pyramid chart. #1053

wants to merge 4 commits into from

Conversation

Sarah-W
Copy link

@Sarah-W Sarah-W commented Dec 3, 2015

Useful for population demographics and whereever your data comes in pairs you want to compare.

@gordonwoodhull
Copy link
Contributor

Thanks @Sarah-W! Looks like the canonical name for this kind of chart is "diverging stacked bar chart", or in this case "diverging stacked row chart".

Of course, we don't currently support stacking in row charts, so maybe we should just call it a diverging row chart. A pyramid chart seems to be something else, used more for conceptual charts (like the food pyramid).

What I'm going to do here is merge the best from this PR and @ruhley's #943 "paired row chart".

@gordonwoodhull gordonwoodhull added this to the v2.1 milestone Dec 17, 2015
@Sarah-W
Copy link
Author

Sarah-W commented Dec 17, 2015

Sweet! I have made a couple of tweaks since the first PR, will push them now (else it will be the new year before it happens) .

I have no strong feelings about what we call it - pyramid is a bit of a misnomer for the New Zealand demographic data anyway, as it is more of a slightly worrying hourglass shape...

@gordonwoodhull gordonwoodhull mentioned this pull request Dec 17, 2015
1 task
@gordonwoodhull
Copy link
Contributor

Here's a branch with both versions included, for comparison and eventual combination into the best-of-both:
https://github.com/dc-js/dc.js/tree/pyramid-paired

I've run out of time for today!

@Sarah-W
Copy link
Author

Sarah-W commented Dec 18, 2015

Well I've run out of time for this year. :) I will be not so much AFK as AF-IDE till early January. I look forward to seeing what you do with it.

@gordonwoodhull
Copy link
Contributor

Screenshot
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants