-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid tmp table name when using: unique_tmp_table_suffix #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atommych
changed the title
remove dashes from ´__dbt_tmp´ suffix
Invalid tmp table name when using: unique_tmp_table_suffix
Nov 8, 2024
nicor88
approved these changes
Nov 8, 2024
@atommych could you have a look at the interagration tests? They might need to be readapted |
Hi @nicor88 , I will work on it till Friday! Thanks for the tips |
4 tasks
Hi @nicor88, the integration test are good now! |
@colin-rogers-dbt and @mikealfare could you please have a look? this looks good to be merged. @atommych update your branch with main then we are ready to go. |
colin-rogers-dbt
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using unique_tmp_table_suffix=True, the UUID added generated contain dashes which causes the following error:
mismatched input '-'. Expecting: '(', '.', 'AS', 'COMMENT', 'WITH'
Checklist