-
-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/anim controller reader attribute #266
Open
niggo1243
wants to merge
15
commits into
dbrizov:master
Choose a base branch
from
niggo1243:feature/anim-controller-reader-attribute
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/anim controller reader attribute #266
niggo1243
wants to merge
15
commits into
dbrizov:master
from
niggo1243:feature/anim-controller-reader-attribute
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y improve the gathering of the required properties and attributes
… it can be used in scriptable objects aswell. also added caching
…in the base property drawers but dont know how to reach them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use the selectable Animator Controller params feature in Scriptable Objects aswell, I modified the anim params attribute property drawer to detect animator controllers aswell.
Also added caching to avoid repetetive reflection calls to get the anim controller.
This branch is based on the lag fix #133 but the anim property drawer code can be used independently if wanted.