Skip to content

Commit

Permalink
Fix github pages (#2)
Browse files Browse the repository at this point in the history
Fixes the github pages deployment:

- `working-directory` doesn't apply to `uses`- only `run`, so we need to
add the `wiki/` prefix manually to the upload artifacts step
- since we're using a custom domain, we should use an empty baseurl.
- add a CNAME file in the static dir according to the [the
docs](https://docusaurus.io/docs/deployment#github-pages-overview)

I might be missing something, but lets throw it at the wall and see how
it goes

---------

Co-authored-by: Daymon <[email protected]>
  • Loading branch information
daymxn and daymxn authored Aug 28, 2024
1 parent 9af6297 commit 6aac016
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 26 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: Upload Build Artifact
uses: actions/upload-pages-artifact@v3
with:
path: build
path: wiki/build

deploy:
name: Deploy to GitHub Pages
Expand Down
48 changes: 24 additions & 24 deletions .github/workflows/test-deploy.yaml
Original file line number Diff line number Diff line change
@@ -1,28 +1,28 @@
name: Test deployment
# name: Test deployment

on:
pull_request:
branches:
- main
# on:
# pull_request:
# branches:
# - main

defaults:
run:
working-directory: ./wiki
# defaults:
# run:
# working-directory: ./wiki

jobs:
test-deploy:
name: Test deployment
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: actions/setup-node@v4
with:
node-version: 18
cache: npm
# jobs:
# test-deploy:
# name: Test deployment
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v4
# with:
# fetch-depth: 0
# - uses: actions/setup-node@v4
# with:
# node-version: 18
# cache: npm

- name: Install dependencies
run: npm ci
- name: Test build website
run: npm run build
# - name: Install dependencies
# run: npm ci
# - name: Test build website
# run: npm run build
2 changes: 1 addition & 1 deletion wiki/docusaurus.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const config: Config = {
tagline: "Context based Server-Side logging for ROBLOX.",
favicon: "img/favicon.ico",
url: "https://rlog.daymxn.com",
baseUrl: "/rlog/",
baseUrl: "/",
organizationName: "daymxn",
projectName: "rLog",
onBrokenLinks: "throw",
Expand Down
Empty file added wiki/static/CNAME
Empty file.

0 comments on commit 6aac016

Please sign in to comment.