- fix potential leak in find_trim(...)

davidbyttow · Dec 6, 2021 · 805153a · 805153a
1 parent 602780f
commit 805153a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/resources/png-alpha-64bit.PNG_64bit_OptimizeICCProfile-macos-12.golden.png b/resources/png-alpha-64bit.PNG_64bit_OptimizeICCProfile-macos-12.golden.png
diff --git a/vips/image.go b/vips/image.go
@@ -1053,7 +1053,12 @@ func (r *ImageRef) OptimizeICCProfile() error {
 
 	embedded := r.HasICCProfile() && (inputProfile == "")
 
-	out, err := vipsICCTransform(r.image, r.optimizedIccProfile, inputProfile, IntentPerceptual, 0, embedded)
+	depth := 16
+	if r.BandFormat() == BandFormatUchar || r.BandFormat() == BandFormatChar || r.BandFormat() == BandFormatNotSet {
+		depth = 8
+	}
+
+	out, err := vipsICCTransform(r.image, r.optimizedIccProfile, inputProfile, IntentPerceptual, depth, embedded)
 	if err != nil {
 		govipsLog("govips", LogLevelError, fmt.Sprintf("failed to do icc transform: %v", err.Error()))
 		return err