Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][test] Fixes GetPartitionMetadataTest checking for linux NIC speed #343

Closed
wants to merge 1 commit into from

Conversation

nikhil-ctds
Copy link
Collaborator

Motivation

This PR fixes the GetPartitionMetadataTest and GetPartitionMetadataMultiBrokerTest that is consistently failing in post commit job.

Modifications

Set LoadBalancerOverrideBrokerNicSpeedGbps configuration manually so that the test doesn't try to fetch from the Linux instance.
This test doesn't depend on NIC speed functionally.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below or label this PR directly (if you have committer privilege).

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@nikhil-ctds nikhil-ctds deleted the 3.1_ds_fix_nicspeed_for_tests branch November 19, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants