Update websocket proxy properly when user/password used #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide new attribute when Node is created that allows to don't use proxy for any request for that connection. Default value is set to use proxy.
When Node is created, proxies to be used for the give connection can be defined at this time. Any request will make use of those proxies.
When user/password is provided in the proxy http://username:password@hostname:port hostname and port have to be extracted properly in order to pass them to the websocket.
kprav33n
requested changes
Dec 8, 2021
| # if username:password is provided, it has to be removed in | ||
| # order to retrive host and port properly. | ||
| if "@" in proxyUrl: | ||
| proxyUrl = "http://{}".format(proxyUrl.split("@")[1]) |
There was a problem hiding this comment.
Should we handle https correctly? This looks like we'll be forcing http irrespective of what is set in the _userProxies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user/password is provided in the proxy
http://username:password@hostname:port
hostname and port have to be extracted properly in order to pass them to
the websocket.