Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add io finished callback to RaftLogStorage::save_vote #1131

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ukernel
Copy link

@ukernel ukernel commented Jun 12, 2024

Checklist

  • Updated guide with pertinent info (may not always apply).
  • Squash down commits to one or two logical commits which clearly describe the work you've done.
  • Unittest is a friend:)

This change is Reviewable

Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a lot changes :)

Can you explain the design purpose of this PR?

And since LogEventChannel is the major component of this PR, it requires some doc comment explaining the function of it.
And test should be added to such an important component.

And I do not quite get it why do you use the notify channel for receiving callback event. It's designed to receive all of the internal event.
https://github.com/datafuselabs/openraft/blob/30cdf5fbc9275ce6213ca8f70cf37bc0c6fe957a/openraft/src/core/raft_core.rs#L201

Reviewable status: 0 of 11 files reviewed, all discussions resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants