Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not persist checkout credentials in GitHub workflows #7044

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

do not persist checkout credentials in GitHub workflows #7044

wants to merge 1 commit into from
+64 −0

Conversation

firewave
Copy link
Collaborator

based on zizmor analysis

@firewave
Copy link
Collaborator Author

Example:

warning[artipacked]: credential persistence through GitHub Actions artifacts
   --> /mnt/s/GitHub/cppcheck-fw/.github/workflows/CI-unixish.yml:178:9
    |
178 |       - uses: actions/checkout@v4
    |         ------------------------- does not set persist-credentials: false
    |
    = note: audit confidence → Low

See actions/checkout#485 for more context.

@firewave
Copy link
Collaborator Author

I filed tickets about addressing the remaining findings:
https://trac.cppcheck.net/ticket/13351
https://trac.cppcheck.net/ticket/13352

@firewave firewave marked this pull request as ready for review November 26, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@firewave