-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use RxJS 5.4.2 to fix generics checking in TS 2.4.1 #1799
Conversation
What's the status of this? This is only a bugfix release according to semver and RxJS's changelog, but brings support for TypeScript 2.4, which is awesome 👍 |
@GulinSS could you even update to RxJS v5.4.3? That one came out in the meantime and adds support for TypeScript v2.4.2.
|
If they update the Rxjs version in the framework/app-base repo, then we can update it here. We're keeping the dependencies as consistent as possible. https://github.com/ionic-team/ionic2-app-base/blob/master/package.json#L29 |
TypeScript is now at 2.5 and this module being stuck at 2.3 is preventing me from updating my project. It looks like the only merge conflict is the package.json file. Can somebody please resolve this? |
@mbielski No they simply to refuse to pull this in, since the "ionic2-app-base" project needs to be updated first. My PR is open since >1 week now without any feedback. |
@timbru31 Did I hear my name? 💃 |
We didn't refuse to merge it, we're trying to be careful about dependency changes that can break things. It's going to take longer than a week to merge PRs given all the moving parts. We appreciate the contribution and understanding |
I can understand a week or two, even three. This is 8 days short of 2 months. The version of TypeScript proposed in the PR isn't even the current version anymore. I don't expect all projects to stay on current versions of all dependencies, but staying updated on current versions of core things like TypeScript seem to me like they should be a much higher priority. |
Unfortunately, even typescript updates can cause unforeseen issues and staying on the latest release of any dependency is not our number one priority (stability is more important in most cases). We prioritize staying in sync with Ionic 2 app base, which is at 2.3.4. We will adjust this soon, once we have the chance to test and confirm there aren't any issues. |
https://github.com/ionic-team/ionic2-app-base has been updated with rxjs 5.4.3 (via ionic-team/ionic2-app-base@fb3a008) - can we update this PR please? It's blocking our TS update to 2.4+ since months. |
#2036 does the same. |
Fix for #1798