-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Angular 18 support #199
Conversation
BREAKING CHANGE: Clients need to use Angular 18 to consume the latest version of this library. Additionally, the browser support was updated to match the browsers that are supported by angular itself and the demo application was updated to include a second demo for the date-time inline component.
@danielmoncada would you mind checking this out please? :) |
Based on the activity in this repository it may seem like the original maintainer moved on from this project. @NetWin - I see that you're quite active, so perhaps you can consider maintaining your fork, and we move over there. Just a thought. |
Yeah i was thinking about this aswell. I even published a version under my npm scope already. |
I saw it and tried it. I ran into #197 and #194 when using standalone components, particularly because it couldn't inject the DateAdapter. I was able to work around it by adding |
That's great! Okay i will take a look later and check what needs to be done to convert the library to standalone / make it work in an angular app that uses standalone components. I'll post here when i have an update. 👍 |
Edit: We now tested it and it works fine in 4 different Angular applications for us at work. So if anyone needs it, feel free to use: https://www.npmjs.com/package/@netwin/angular-datetime-picker If you encounter any problems, feel free to create an issue here: https://github.com/NetWin/date-time-picker Regarding the issues pointed out above. We imported both the I think the reason for these issues is that the Date picker does not work with JS Dates out of the Box. It's implemented in a generic way where you import the components via the I'm currently working on a full upgrade of this library. (Strictmode, standalone, signals, improved documentation etc.) but this will take some time as i have to get familiar with the codebase first. |
I'm still here. I will merge this and publish. I apologize for the absence, been pretty busy at work. |
published, thank you @NetWin for the PR |
Changes
(i just created a new ng18 app and copied the
.browserslistrc
file)sass
withscss