Increased date time adapter compatibility #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added two public variables to DateTimeAdapter class to increase compatibility
Added two protected variables to NativeDateTimeAdapter class to match the base DateTimeAdapter class interface
Added two protected variables to UnixTimestampDateTimeAdapter class to match the base DateTimeAdapter class interface
Modified generateWeekDays method to include DateTimeAdapter firstDayOfTheWeek variable
Modified selectYear, createYearCell, & isYearEnabled methods to replace hard-coded first month integer with DateTimeAdapter firstMonthOfTheYear variable
Modified generateMonthList & createMonthCell methods to include DateTimeAdapter firstMonthOfTheYear variable
|
thank you @Venators , left a comment |
| @@ -26,6 +26,9 @@ const ISO_8601_REGEX = /^\d{4}-\d{2}-\d{2}(?:T\d{2}:\d{2}:\d{2}(?:\.\d+)?(?:Z|(? | |||
|
|
|||
| @Injectable() | |||
| export class NativeDateTimeAdapter extends DateTimeAdapter<Date> { | |||
| protected firstMonthOfTheYear: number = 0; | |||
There was a problem hiding this comment.
@Venators for all the time adapters, you've incorrectly extended the base class, causing a build error for production.
DateTimeAdapter has firstMonthOfTheYear and firstDayOfTheWeek public, but the derived adapters are changing the access modifiers to something more strict (protected).
There was a problem hiding this comment.
Hi @danielmoncada - my apologies for that mix-up.
The code should be corrected now with the matching & appropriate access modifiers.
Corrected the access modifiers to match the parent
Corrected the access modifiers to match the parent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to the date-time picker's date implementation agnostic nature, it's easy for developers to work with their preferred date implementations. Out of the gate, they are treated to four pre-made modules: Native, Unix Timestamp, DayJs, and Moment.
However, all four of those date implementations use 0-indexed day of the week and month arrays, and subsequently, the date-time picker has hard-coded variables and 0-based logic that makes the library partially incompatible with date implementations that use different indexing, like Luxon, regardless of the custom date-time adapter in use.
The minor changes in this PR retain the current behaviour and compatibility with the current 0-indexed date implementations whilst also increasing the library's compatibility with 1-indexed date implementations.