forked from DanielYKPan/date-time-picker
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular 17 support #189
Merged
Merged
Angular 17 support #189
Changes from 10 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
20e684e
1
pavlikxor 1066115
2
pavlikxor 5ec6dd5
3
pavlikxor 2b57dca
4
pavlikxor 8cfd316
5
pavlikxor b72f67d
5
pavlikxor 639c329
6
pavlikxor 7d39604
7
pavlikxor 4490efe
7
pavlikxor 1e3c5b9
version update
pavlikxor 110dc93
CR feedback
pavlikxor 099fa04
clean up minor import errors
pavlikxor 6bfcdfd
Readme update
pavlikxor aaea1ec
Merge branch 'master' into feature/ng-17
pavlikxor 43e17a1
fix: missing arg when firing observable
danielmoncada 8e98ddd
chore: update readme
danielmoncada 99ffed7
fix: zone imports
danielmoncada File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ cache: | |
addons: | ||
chrome: stable | ||
before_script: | ||
- npm install -g @angular/cli@9.0.4 | ||
- npm install -g @angular/cli@latest | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This works until Angular introduces breaking changes to the cli package... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks, fixed version used |
||
- npm install | ||
script: | ||
- npm run test-with-coverage | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought Angular 17 required node 18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, updated