Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 17 support #189

Merged
merged 17 commits into from
Dec 4, 2023
2 changes: 1 addition & 1 deletion .github/workflows/ci_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v1
with:
node-version: '14.16.1'
node-version: '16.16.0'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought Angular 17 required node 18

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated

- name: Install dependencies
run: npm install
- name: Run tests
Expand Down
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ cache:
addons:
chrome: stable
before_script:
- npm install -g @angular/cli@9.0.4
- npm install -g @angular/cli@latest

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works until Angular introduces breaking changes to the cli package...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed version used

- npm install
script:
- npm run test-with-coverage
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
[![npm](https://img.shields.io/npm/v/@danielmoncada/angular-datetime-picker.svg?maxAge=2592000?style=flat-square)](https://www.npmjs.com/package/@danielmoncada/angular-datetime-picker)
[![npm](https://img.shields.io/npm/dm/@danielmoncada/angular-datetime-picker.svg)](https://www.npmjs.com/package/@danielmoncada/angular-datetime-picker)

** *This package supports Angular 9/10/11/12/13/14/15/16**
** *This package supports Angular 9/10/11/12/13/14/15/16/17**

Breaking Changes
-------
Expand Down
9 changes: 4 additions & 5 deletions angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -73,18 +73,18 @@
"serve": {
"builder": "@angular-devkit/build-angular:dev-server",
"options": {
"browserTarget": "date-time-picker-app:build"
"buildTarget": "date-time-picker-app:build"
},
"configurations": {
"production": {
"browserTarget": "date-time-picker-app:build:production"
"buildTarget": "date-time-picker-app:build:production"
}
}
},
"extract-i18n": {
"builder": "@angular-devkit/build-angular:extract-i18n",
"options": {
"browserTarget": "date-time-picker-app:build"
"buildTarget": "date-time-picker-app:build"
}
},
"test": {
Expand Down Expand Up @@ -186,6 +186,5 @@
}
}
}
},
"defaultProject": "date-time-picker-app"
}
}
Loading