Skip to content

Commit

Permalink
Add files via upload
Browse files Browse the repository at this point in the history
Documentation and code comments updated with new debugging test results
  • Loading branch information
danielhatton authored Jun 8, 2020
1 parent ec34d53 commit 99173a6
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 3 deletions.
5 changes: 4 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,10 @@ methods exit. Unfortunately, adding commands to the end of the
methods to close the dummy documents causes a segfault, at least under
FreeCAD 0.16 on Scientific Linux 7.3 (and in some cases under FreeCAD
0.16 on Fedora 28), so the methods currently leave the dummy documents
open.
open. The segfault doesn't happen under FreeCAD 0.18.4 on Ubuntu
20.04, so at some point in the future, it's likely to be safe to
uncomment the commands in `eights.py` that will close the dummy
documents.

In setting the widths of lines in the drawing to comply with BS
8888:2011, both the `put_it_in` method in the
Expand Down
10 changes: 8 additions & 2 deletions eights.py
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,10 @@ def put_it_in(self,dummy):
# dummy document causes a segfault, at least under
# FreeCAD 0.16 on Scientific Linux 7.3 and FreeCAD
# 0.16 on Fedora 28, so the following command is
# commented out.
# commented out. (The segfault doesn't happen under
# FreeCAD 0.18.4 on Ubuntu 20.04, so at some point in
# the future, it's likely to be safe to uncomment the
# command.)

# FreeCAD.closeDocument("Dummy")

Expand Down Expand Up @@ -431,6 +434,9 @@ def fap(self,dummy):
# that already contains views of one shape, attempting
# to close the dummy document causes a segfault, at
# least under FreeCAD 0.16 on Scientific Linux 7.3, so
# the following command is commented out.
# the following command is commented out. (The
# segfault doesn't happen under FreeCAD 0.18.4 on
# Ubuntu 20.04, so at some point in the future, it's
# likely to be safe to uncomment the command.)

# FreeCAD.closeDocument("Dummy")

0 comments on commit 99173a6

Please sign in to comment.