chore: bump node and finally fix pnpm :amaze: #3871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebelchris
requested review from
omBratteng,
ilasw,
capJavert,
sshanzel,
nensidosari and
AmarTrebinjac
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rebelchris
commented
Nov 22, 2024
| @@ -19,8 +19,12 @@ import { | |||
| TypographyType, | |||
| } from './typography/Typography'; | |||
|
|
|||
| const ReactMarkdown = dynamic( | |||
| () => import(/* webpackChunkName: "reactMarkdown" */ 'react-markdown'), | |||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | |||
There was a problem hiding this comment.
packages/webapp/pages/onboarding.tsx
Outdated
| @@ -291,8 +291,8 @@ export function OnboardPage(): ReactElement { | |||
| <img | |||
| alt="Onboarding background" | |||
| className="pointer-events-none absolute inset-0 -z-1 h-full w-full object-cover tablet:object-center" | |||
| // @ts-expect-error - Not supported by react yet | |||
| fetchpriority="high" | |||
| /* eslint-disable react/no-unknown-property */ | |||
There was a problem hiding this comment.
Not even sure why left worked on older node
|
I've tested locally and test passed without errors, maybe circleci is using old packages from cache and we need to update file version on config.yml? |
capJavert
reviewed
Nov 26, 2024
| steps: | ||
| - checkout | ||
| - run: | ||
| name: Install pnpm | ||
| command: npm i --prefix=$HOME/.local -g pnpm@8.15.7 | ||
| command: npm i --prefix=$HOME/.local -g pnpm |
There was a problem hiding this comment.
We should still provide specific version, for example if pnpm 10.x comes and it has breaking our ci/cd would break again.
There was a problem hiding this comment.
Yeah good point, will adjust
| @@ -38,7 +38,7 @@ tasks: | |||
| nvm install | |||
| nvm use | |||
| init: | | |||
| npm i -g pnpm@8.15.7 | |||
| npm i -g pnpm | |||
There was a problem hiding this comment.
also as my comment above, let's set sepcific version
| @@ -81,7 +81,7 @@ https://github.com/dailydotdev/.github/blob/master/CONTRIBUTING.md | |||
| After cloning the project, please make sure to run the following commands to bootstrap the project: | |||
|
|
|||
| ```bash | |||
| npm i -g pnpm@8.15.7 | |||
| npm i -g pnpm | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Upgrade node
Upgrade pnpm finally, figured it's actually just a change they did in 9 for workspaces:
link-workspace-packages: disabled by default. This means that by default, dependencies will be linked from workspace packages only when they are specified using the workspace protocol.
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Preview domain
https://chore-bumps.preview.app.daily.dev