-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependency: Update jQuery to latest #30345
Open
jennifer-shehane
wants to merge
23
commits into
release/14.0.0
Choose a base branch
from
remove-jquery-patch
base: release/14.0.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING: remove the patch that was preventing width/height calculation changes
cypress Run #57610
Run Properties:
|
Project |
cypress
|
Run status |
Failed #57610
|
Run duration | 23m 30s |
Commit |
fc9aef2df0: Merge branch 'remove-jquery-patch' of https://github.com/cypress-io/cypress into...
|
Committer | Jennifer Shehane |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
4
|
Flaky |
7
|
Pending |
1326
|
Skipped |
0
|
Passing |
29386
|
UI Coverage
44.77%
|
|
---|---|
Untested elements |
201
|
Tested elements |
167
|
Accessibility
91.3%
|
|
---|---|
Failed rules |
5 critical
10 serious
2 moderate
2 minor
|
Failed elements |
938
|
Tests for review
cypress/e2e/e2e/focus_blur.cy.js • 1 failed test • 5x-driver-electron
Test | Artifacts | |
---|---|---|
intercept blur methods correctly > focus <iframe> |
Test Replay
|
cypress/e2e/e2e/focus_blur.cy.js • 1 failed test • 5x-driver-chrome:beta
Test | Artifacts | |
---|---|---|
intercept blur methods correctly > focus <iframe> |
Test Replay
|
cypress/e2e/e2e/focus_blur.cy.js • 1 failed test • 5x-driver-firefox
Test | Artifacts | ||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
intercept blur methods correctly > focus <iframe> |
cypress/e2e/e2e/focus_blur.cy.js • 1 failed test • 5x-driver-chrome
waiting.cy.js • 2 flaky tests • 5x-driver-chrome:beta
querying/querying.cy.js • 1 flaky test • 5x-driver-chrome
waiting.cy.js • 1 flaky test • 5x-driver-chrome
net_stubbing.cy.ts • 3 flaky tests • 5x-driver-webkit
|
…ypress into remove-jquery-patch
jennifer-shehane
changed the title
breaking: Remove patch of jQuery - updating width/height calculations for elements
breaking: Update jQuery to latest
Oct 8, 2024
jennifer-shehane
added
the
type: breaking change
Requires a new major release version
label
Oct 8, 2024
jennifer-shehane
changed the title
breaking: Update jQuery to latest
dependency: Update jQuery to latest
Oct 8, 2024
…Query is moving away from sizzle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Keeping the width/height patch we intended originally to remove
Bumping jQuery
This PR bumps jQuery to 3.7.1 which is latest. 4.0.0 of jQuery is still in Beta.
Steps to test
All tests should pass
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?