Fixed statistics for single-cycle core, fixed BHR UI not disabling pr…

…operly
cvut · Aug 26, 2024 · ab6692e · ab6692e
1 parent edf5156
commit ab6692e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/src/gui/windows/predictor/predictor_info_dock.cpp b/src/gui/windows/predictor/predictor_info_dock.cpp
@@ -91,7 +91,7 @@ DockPredictorInfo::DockPredictorInfo(QWidget *parent) : Super(parent) {
 
     // Stats
     label_stats_total_text->setText("Jump/Branch count:");
-    label_stats_miss_text->setText("Flush count:");
+    label_stats_miss_text->setText("Misprediction count:");
     label_stats_accuracy_text->setText("Total accuracy:");
     clear_stats();
 
@@ -223,6 +223,11 @@ void DockPredictorInfo::setup(
         value_bhr->setEnabled(false);
     }
 
+    if (number_of_bhr_bits == 0) {
+        label_bhr->setEnabled(false);
+        value_bhr->setEnabled(false);
+    }
+
     clear_bhr();
 }
 

diff --git a/src/machine/core.cpp b/src/machine/core.cpp
@@ -532,6 +532,11 @@ MemoryState Core::memory(const ExecuteInterstage &dt) {
         }
     }
 
+    // Predictor statistics update
+    if (computed_next_inst_addr != dt.predicted_next_inst_addr) {
+        predictor->increment_mispredictions();
+    }
+
     return { MemoryInternalState {
                  .mem_read_val = towrite_val,
                  .mem_write_val = dt.val_rt,
@@ -721,11 +726,7 @@ void CorePipelined::handle_stall(const FetchInterstage &saved_if_id) {
 }
 
 bool CorePipelined::detect_mispredicted_jump() const {
-    bool misprediction = mem_wb.computed_next_inst_addr != mem_wb.predicted_next_inst_addr;
-    if (misprediction) {
-        predictor->increment_mispredictions();
-    }
-    return misprediction;
+    return mem_wb.computed_next_inst_addr != mem_wb.predicted_next_inst_addr;
 }
 
 bool CorePipelined::is_stall_requested() const {