Fix some tests #91
Fix some tests #91
Conversation
dwalluck
commented
Apr 15, 2024
dwalluck
commented
- Fix test exit codes
- Fix file separators
- Don't use shell glob when not in shell (always set outputFileName)
- Always set working directory of ProcessBuilder
- Don't call external sort command (use Groovy when sort is needed)
| proc.waitFor() | ||
| return proc.in.getText().trim() | ||
| return proc.in.getText().split().sort() |
There was a problem hiding this comment.
As the sort order seems important here, we should not change this.
There was a problem hiding this comment.
It should just be a "better" way of keeping the same behavior as before.
I removed the call to sort -n (which only works in a shell) and replaced it with pure Groovy split().sort().
There was a problem hiding this comment.
Note that this pull request currently causes some test failures, but this one passes.
I think that the test failures are correct now and show some issues with the packager code.
dwalluck
force-pushed
the
fix-exit-codes
branch
from
5a20e6b
to
27f41b3
Compare
* Fix test exit codes * Fix file separators * Don't use shell glob when not in shell (always set outputFileName) * Always set working directory of ProcessBuilder * Don't call external sort command (use Groovy when sort is needed)
dwalluck
force-pushed
the
fix-exit-codes
branch
from
27f41b3
to
9582b5f
Compare
|
@ctron The tests pass with the exception of the test yum1. The yum1 test is using a file in the source tree ( |
|
@ctron I added I am not sure if you want to fix that test first. |
