Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace name property by simple attribute #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

huard
Copy link
Collaborator

@huard huard commented Oct 16, 2024

Fix #63

Copy link
Contributor

@mishaschwartz mishaschwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Is there a reason that the prefix and the name were linked before? Is there any value in trying to enforce that the prefix and the name are the same?

@huard
Copy link
Collaborator Author

huard commented Oct 16, 2024

I suspect not having this consistency might break some of the STAC stuff. Note that this consistency is ensured in the cordex_extension branch. I'll be able to port the changes to CMIP6 once we agree on the framework.

Copy link
Collaborator

@fmigneault fmigneault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason that the prefix and the name were linked before?

Yes!

Look at how many duplicate "cmip6" hard-coded values there are now.
It's very easy to forget one here and there. The previous approach allowed for anything to reference the same SchemaName. Changing it was a single-place edit.

The name class attribute replacement from a property to fix pystac interoperability is good, but I think a single "source of truth" should remain with SchemaName.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pystac extension not handling well name property
3 participants