Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update try minikube link #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update try minikube link #41

wants to merge 1 commit into from

Conversation

mazzystr
Copy link

@mazzystr mazzystr commented Apr 8, 2020

Hello,
This is a quick PR to update the broken link for "Try Minikube"

@openshift-ci-robot openshift-ci-robot added the dco-signoff: no Indicates the PR's author has not DCO signed all their commits. label Apr 8, 2020
@openshift-ci-robot
Copy link

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mazzystr
To complete the pull request process, please assign umohnani8
You can assign the PR to them by writing /assign @umohnani8 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member

Hey @mazzystr, the changes are looking good to me but can you please sign your commits via git commit --amend -s?

@afbjorklund
Copy link

The new link is: https://minikube.sigs.k8s.io/docs/handbook/config/#runtime-configuration

Other link is valid too, but it goes to kubeadm (production) rather than minikube (learning)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: no Indicates the PR's author has not DCO signed all their commits.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants