Feat/make safari extension great again #140
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While Chrome and Firefox seems not to care about this permission, Safari displays an error about missing `activeTab` I'm not sure about the impact of this modification as the only observed effect is the disappearing of the error message (app was still loading without it)
`inPageMenu` was not present in the XCode project. This resulted on folder not present in the extension package's content and the `in-page` Cozy menu was not loaded by Safari
Previous `DEVELOPMENT_TEAM` was corresponding to Bitwarden's team id Current corresponds to Cozy team and was taken from https://developer.apple.com/account/resources/profiles/list (displayed on top right, under account's name) This edit seems not enough to make code signature correctly working App is building but there are console warning during buid about missing signatures
We wan't to adapt the BundleIdentifier to avoid conflict with Bitwarden extension if installed in parallel of Cozy Pass extension
This entitlement was present on Bitwarden's project but not on Cozy's project
`chrome` api seems not to be correctly handled by Safari but `browser` one should I made the replacement on all `inPageMenu` related content scripts (so not the entire code) This fixes some behaviours (localization) but not all (messaging). So I'm not sure that this is the correct thing to do
Previous code was using a pointer to `browser.i18n.getMessage` to handle multiple calls to translation methods This is not working on Safari, so we have to repeat `browser.i18n.getMessage` each time we want to get translated messages
Previous implementation was generating urls in the form `file.html?params=XXXX?123456789` Problem is that is contains two `?` in the url, which should not be valid By inverting both variables we can generate urls in the form `file.html?123456789¶ms=XXXX` This is an attempt to fix a Safari error stating that resource is missing on server side (when refreshing the extension's iframe) This does not fix this issue, but I would say that the new form is more correct
This is for a test while investigating error message when open/closing the inPageMenu When clicking the cloud image in a field, nothing happens expect having an error message on the console stating `Failed to load resource The requested URL was not found on this server` This seems to be related to those line when changing the menuEl.src, then iFrame's url is refreshed and this message appears I still don't understand what prevents the iFrame to refresh, knowing that the first display is based on the same URL (only args are changing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO_NOT_MERGE).So do not try to merge this PR without reworking and testing ALL existing commits.
Introduction
This PR's goal is to fix Safari extension. This consist of fixing the build process, the installation process, the extension's background worker, the extension's popup and the extension's in-app menu. We also may have to fix the store publish process.
Current status
This PR is in an
idlestate, no work is intended on it until we prioritise it againTasks:
Developer ID Application: Cozy Cloud (3AKXFMV43J): no identity foundappearing in thenpm run dist:safari's outputdesktopand should beCozy Pass(or similar)cloudimage in a field does not trigger the menu popovertransform: scale(0)from the iframe's.paneldivkeychainicon is displayed on top ofcloudiconloginMenu.jsnear line 120,console.log('Received message ', msg)is never calledMore info
More info can be found on the team's paper
Développement et publication - Pass (extension)in section02/12/2021 : Exploration remise en marche de Safari