Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assistant : Extract Search from Chat #2212

Merged
merged 15 commits into from
Oct 16, 2024
Merged

Assistant : Extract Search from Chat #2212

merged 15 commits into from
Oct 16, 2024

Conversation

JF-Cozy
Copy link
Contributor

@JF-Cozy JF-Cozy commented Oct 16, 2024

No description provided.

Copy link

bundlemon bot commented Oct 16, 2024

BundleMon

Files updated (4)
Status Path Size Limits
vendors/home.(hash).js
1.51MB (+8.58KB +0.56%) -
intents/home.(hash).js
26.78KB (+982B +3.71%) -
app/home.(hash).js
52.08KB (+233B +0.44%) -
app-home.(hash).min.css
2.14KB (+18B +0.83%) -
Unchanged files (9)
Status Path Size Limits
services/softDeleteOrRestoreAccounts/home.js
464.4KB -
services/updateAccounts/home.js
461.47KB -
services/deleteAccounts/home.js
309.8KB -
services/myselfFromIdenties/home.js
234.35KB -
services/polyfillFetch/home.js
97.37KB -
vendors-home.(hash).(hash).min.css
38.79KB -
services/attributesHelpers/home.js
15.22KB -
intents/index.html
648B -
intents-home.(hash).min.css
158B -

Total files change +9.78KB +0.3%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

src/assistant/Views/AssistantDialog.jsx Outdated Show resolved Hide resolved
@JF-Cozy
Copy link
Contributor Author

JF-Cozy commented Oct 16, 2024

Je merge en l'état pour avancer également le sujet du search qui est dépendant de cette modification. En revanche on a noté deux corrections à faire :

  • la searchBar n'est pas fixed en bas de l'écran il faut scroller si beaucoup d'icone d'app
  • les badges shortcut des app shortcut passe par-dessus le result sur desktop

image

@JF-Cozy JF-Cozy merged commit c758d0c into master Oct 16, 2024
3 checks passed
@JF-Cozy JF-Cozy deleted the feat/VER-992 branch October 16, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants